fix failing installation for tests #862
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ffmpegwasm canceled.
|
|
I replaced http-server with serve. So at least the multi-threaded tests start executing locally again, but still fail: 
RuntimeError: Out of bounds memory access (evaluating 'Module["_ffmpeg"](args.length,stringsToPtr(args))')<?>.wasm-function[1894]@[wasm code]
<?>.wasm-function[1725]@[wasm code]
<?>.wasm-function[6106]@[wasm code]
<?>.wasm-function[810]@[wasm code]
<?>.wasm-function[4106]@[wasm code]
<?>.wasm-function[1719]@[wasm code]
<?>.wasm-function[8312]@[wasm code]
<?>.wasm-function[85]@[wasm code]
<?>.wasm-function[18631]@[wasm code]
exec@http://localhost:3000/packages/core-mt/dist/umd/ffmpeg-core.js:8:1229
@http://localhost:3000/tests/ffmpeg-core.test.js:51:21not sure why this is failing for a different reason on CI though: https://github.com/japj/ffmpeg.wasm/actions/runs/14285449729/job/40040006250 
|
|
fixed the 301 issue with serve The multithreaded tests still fail, both locally and in CI. |
|
I now see that there is another related pullrequest trying to solve failing install/test core-mt test failures at #842 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ONLY fixes the failing installation of test step in Github CI.
The single threaded tests are passing, but the multi-threaded tests are (still) failing in the CI job.